Hi Bernd,

Thanks for updating the macro. Although I haven't used it, it's nice to know it's available and up-to-date. I have not tested it, but looking at the code, it looks solid. There are a few places were you could refactor it for readability but overall I don't see glaring issues.

The one deficiency I do see is automated tests for it. I've recently written an Activity with testing which required breaking out the operations into separate subroutines. This actually made the code not just more testable, but also far more readable than when I had stuffed all my logic and operations into one long method call. I'd be glad to share my test or you can just look in WebGUI/t for lots of examples.

Cheers,
William

----
Knowmad Technologies
http://www.knowmad.com

Hi Bernd,

Breaking your code into subroutines is partly what I meant, but let me give you some examples of refactoring for readability. Instead of writing

    $minutes = 5 if ($minutes eq "");
    $maxMembers = 10 if ($maxMembers eq "");

use

    $minutes ||= 5;
    $maxMembers ||= 10;

These are Perlism's that make your code easier for Perl programmers to read*. Another example is when you iterate through the rows. Instead of using a counter that is never needed other than for the loop, use a while loop such as:

while (my %row = $result->hash) {

That eliminates code and makes it very clear what you are doing.

Keep up the efforts,
William

* There are some caveats to this technique which have been addressed by the new defined-or (//=) operator in Perl 5.10. This should not affect your code as it stands (and should not be used with WebGUI as it must be compatible with 5.8.x).

----
Knowmad Technologies
http://www.knowmad.com

Hi William,

I have have changed the code according to your recommendations. In addition, there is a help module now. I have posted an update in the "Get Add Ons" section. Next, I am going to work on testing.

Bernd

--
Administrator of a non-profit community portal for free-climbers around Magdeburg/Germany. Check out http://www.klettern-md.de.