Click here to register.
      
PBWG Banner


     Discuss > WebGUI Dev

Thread method overrides method in AssetVersioning

User colink
Date 4/26/2007 4:24 pm
Views 1089
Rating -3    Rate [
|
]
Previous · Next
User Message
colink

Thread has a method to tell if it has been "locked", or set so that no new replies can be added to the thread.

But AssetVersioning.pm also provides an isLocked method, which tells if the Asset is locked for editing.

The Thread method should override the one in the Asset parent class, which means when the Asset checks to see if it is locked for editing, it will return whether or not Posts can be added to it.

I would like to propose that we rename the Thread method to isThreadLocked,  that all instances of Thread based lock checks be renamed to match (Collaboration.pm, Post.pm and any Workflow Activities), and then post a gotcha so that devs who are using this get a heads up about the change in method name.

 



Back to Top
Rate [
|
]
 
 
JT
agreed
On Apr 26, 2007, at 4:24 PM, <ckuskie@sterlink.net> wrote:
colink wrote:

Thread has a method to tell if it has been "locked", or set so that no new replies can be added to the thread.

But AssetVersioning.pm also provides an isLocked method, which tells if the Asset is locked for editing.

The Thread method should override the one in the Asset parent class, which means when the Asset checks to see if it is locked for editing, it will return whether or not Posts can be added to it.

I would like to propose that we rename the Thread method to isThreadLocked,  that all instances of Thread based lock checks be renamed to match (Collaboration.pm, Post.pm and any Workflow Activities), and then post a gotcha so that devs who are using this get a heads up about the change in method name.

 


http://www.plainblack.com/webgui/dev/discuss/thread-method-overrides-method-in-assetversioning

Unsubscribe



-- 
Plain Black&#44; makers of WebGUIhttp://plainblack.com

JT ~ Plain Blackph: 703-286-2525 ext. 810fax: 312-264-5382http://www.plainblack.com
I reject your reality, and substitute my own. ~ Adam Savage





Back to Top
Rate [
|
]
 
 
     Discuss > WebGUI Dev



Recent Discussions Color Key

Design:

Development:

Et Cetera:

Install/Upgrade:  

Smoketest:

Template Group:


Re: Site paid for by advertizing by Klaus - Fri @ 02:27am

Smoke Test for WebGUI (Stable) (2008-11-21) by botaction - Fri @ 12:37am

Re: Site paid for by advertizing by pwrightson - Thu @ 10:59am

Re: Site paid for by advertizing by JT - Thu @ 08:58am

Re: Regelmäßiger Termin für Usertreffen in der Rhein-Neckar-Region by Klaus - Thu @ 06:11am

Smoke Test for WebGUI (Stable) (2008-11-20) by botaction - Thu @ 12:00am

Smoke Test for SVN (2008-11-20) by botaction - Thu @ 12:00am

Re: Improving page layouts by fdillon - Wed @ 08:38pm

Re: Improving page layouts by knowmad - Wed @ 08:25pm

Re: Site paid for by advertizing by knowmad - Wed @ 08:07pm

Re: SSL Configuration? by knowmad - Wed @ 07:51pm

Re: The Death of the Collaboration System by preaction - Wed @ 07:39pm