colink wrote:

Thread has a method to tell if it has been "locked", or set so that no new replies can be added to the thread.

But AssetVersioning.pm also provides an isLocked method, which tells if the Asset is locked for editing.

The Thread method should override the one in the Asset parent class, which means when the Asset checks to see if it is locked for editing, it will return whether or not Posts can be added to it.

I would like to propose that we rename the Thread method to isThreadLocked,  that all instances of Thread based lock checks be renamed to match (Collaboration.pm, Post.pm and any Workflow Activities), and then post a gotcha so that devs who are using this get a heads up about the change in method name.

 


http://www.plainblack.com/webgui/dev/discuss/thread-method-overrides-method-in-assetversioning

Unsubscribe

-- 
Plain Black, makers of WebGUIhttp://plainblack.com