|
Previous
·
Next
|
patspam
|
Date: 7/31/2008 3:30 am · Subject: Overriding inbox emails · Rating: 1
I've attached the diff (from the current trunk) for a small change to WebGUI::Inbox::Message that I would like to commit to the trunk.
It adds two new optional named params to the create sub (emailMessage and emailSubject) so that you can override the message and subject of the email that gets sent out as a result of the call to create().
Why? For a project I'm working on the messages sent to users contain private/sensitive information. Rather than having these messages sent via email I wanted to send only a generic "A new message is waiting for you" message and then let the user read the message contents via their (https secure) WebGUI inbox.
Good? Bad?
Patrick
Attached Files
|
| Back to Top |
Rate [ | ]
|
| |
JT
|
Date: 7/31/2008 8:55 am · Subject: Re: Overriding inbox emails · Rating: 0
What rev is this patched against?
JT
On Jul 31, 2008, at 3:30 AM, <pat@patspam.com> wrote:
patspam wrote:
I've attached the diff (from the current trunk) for a small change to WebGUI::Inbox::Message that I would like to commit to the trunk.
It adds two new optional named params to the create sub (emailMessage and emailSubject) so that you can override the message and subject of the email that gets sent out as a result of the call to create().
Why? For a project I'm working on the messages sent to users contain private/sensitive information. Rather than having these messages sent via email I wanted to send only a generic "A new message is waiting for you" message and then let the user read the message contents via their (https secure) WebGUI inbox.
Good? Bad?
Patrick
http://www.plainblack.com/webgui/dev/discuss/overriding-inbox-emails
--
Plain Black, makers of WebGUI
http://plainblack.com
|
| Back to Top |
Rate [ | ]
|
| |
patspam
|
Date: 7/31/2008 9:15 am · Subject: Re: Overriding inbox emails · Rating: 0
Oh right, um.. 7130
It's a pretty basic patch so I can do it again for the latest version, just checking that the API change/extension is ok.
Patrick
On Thu, Jul 31, 2008 at 11:55 PM, <jt@plainblack.com> wrote:
JT wrote:
What rev is this patched against?
JT
On Jul 31, 2008, at 3:30 AM, <pat@patspam.com> wrote:
patspam wrote:
I've attached the diff (from the current trunk) for a small change to WebGUI::Inbox::Message that I would like to commit to the trunk.
It adds two new optional named params to the create sub (emailMessage and emailSubject) so that you can override the message and subject of the email that gets sent out as a result of the call to create().
Why? For a project I'm working on the messages sent to users contain private/sensitive information. Rather than having these messages sent via email I wanted to send only a generic "A new message is waiting for you" message and then let the user read the message contents via their (https secure) WebGUI inbox.
Good? Bad?
Patrick
http://www.plainblack.com/webgui/dev/discuss/overriding-inbox-emails
--
Plain Black, makers of WebGUI
http://plainblack.com
http://www.plainblack.com/webgui/dev/discuss/overriding-inbox-emails/1
--
Plain Black, makers of WebGUI
http://plainblack.com
|
| Back to Top |
Rate [ | ]
|
| |
JT
|
Date: 8/18/2008 10:37 am · Subject: Re: Overriding inbox emails · Rating: 0
You are approved to add it to the core.
|
| Back to Top |
Rate [ | ]
|
| |
patspam
|
Date: 9/6/2008 12:05 am · Subject: Re: Overriding inbox emails · Rating: 0
A dumb question since this is the first time I've committed an API patch, is the standard practice to just apply this to trunk and not to say, the 7.5 branch?
Patrick
On Tue, Aug 19, 2008 at 1:37 AM, <jt@plainblack.com> wrote:
JT wrote:
You are approved to add it to the core.
http://www.plainblack.com/webgui/dev/discuss/overriding-inbox-emails/3
--
Plain Black, makers of WebGUI
http://plainblack.com
|
| Back to Top |
Rate [ | ]
|
| |
JT
|
Date: 9/6/2008 1:20 am · Subject: Re: Overriding inbox emails · Rating: 0
You only apply bug fixes to a stable branch like 7.5. New features only go in head.
JT
On Sep 6, 2008, at 12:05 AM, <pat@patspam.com> wrote:
patspam wrote:
A dumb question since this is the first time I've committed an API patch, is the standard practice to just apply this to trunk and not to say, the 7.5 branch?
Patrick
On Tue, Aug 19, 2008 at 1:37 AM, <jt@plainblack.com> wrote:
JT wrote:
You are approved to add it to the core.
http://www.plainblack.com/webgui/dev/discuss/overriding-inbox-emails/3
--
Plain Black, makers of WebGUI
http://plainblack.com
http://www.plainblack.com/webgui/dev/discuss/overriding-inbox-emails/4
--
Plain Black, makers of WebGUI
http://plainblack.com
|
| Back to Top |
Rate [ | ]
|
| |
patspam
|
Date: 9/6/2008 2:05 am · Subject: Re: Overriding inbox emails · Rating: 0
Got it, thanks.
Patrick
On Sat, Sep 6, 2008 at 4:20 PM, <jt@plainblack.com> wrote:
JT wrote:
You only apply bug fixes to a stable branch like 7.5. New features only go in head.
JT
On Sep 6, 2008, at 12:05 AM, <pat@patspam.com> wrote:
patspam wrote:
A dumb question since this is the first time I've committed an API patch, is the standard practice to just apply this to trunk and not to say, the 7.5 branch?
Patrick
On Tue, Aug 19, 2008 at 1:37 AM, <jt@plainblack.com> wrote:
JT wrote:
You are approved to add it to the core.
http://www.plainblack.com/webgui/dev/discuss/overriding-inbox-emails/3
--
Plain Black, makers of WebGUI
http://plainblack.com
http://www.plainblack.com/webgui/dev/discuss/overriding-inbox-emails/4
--
Plain Black, makers of WebGUI
http://plainblack.com
http://www.plainblack.com/webgui/dev/discuss/overriding-inbox-emails/5
--
Plain Black, makers of WebGUI
http://plainblack.com
|
| Back to Top |
Rate [ | ]
|
| |
knowmad
|
Date: 9/7/2008 7:12 pm · Subject: Re: Overriding inbox emails · Rating: 0
You only apply bug fixes to a stable branch like 7.5. New features only go in head.
JT,
So how do bug fixes get migrated to head? Do you merge changes back from branches?
William
----
Knowmad Technologies
http://www.knowmad.com
|
| Back to Top |
Rate [ | ]
|
| |
JT
|
Date: 9/7/2008 7:35 pm · Subject: Re: Overriding inbox emails · Rating: 0
Sorry I wasn't specific enough. Bug fixes go into both branches.
JT
On Sep 7, 2008, at 7:12 PM, <william@knowmad.com> wrote:
knowmad wrote:
You only apply bug fixes to a stable branch like 7.5. New features only go in head.
JT,
So how do bug fixes get migrated to head? Do you merge changes back from branches?
William
----
Knowmad Technologies
http://www.knowmad.com
http://www.plainblack.com/webgui/dev/discuss/overriding-inbox-emails/7
--
Plain Black, makers of WebGUI
http://plainblack.com
|
| Back to Top |
Rate [ | ]
|
| |
|
|
Recent Discussions Color Key |
| Design: |
|
| Development: |
|
| Et Cetera: |
|
| Install/Upgrade: |
|
| Smoketest: |
|
| Template Group: |
|
Re: Site paid for by advertizing by Klaus - Fri @ 02:27am Re: Site paid for by advertizing by pwrightson - Thu @ 10:59am Re: Site paid for by advertizing by JT - Thu @ 08:58am Re: Regelmäßiger Termin für Usertreffen in der Rhein-Neckar-Region by Klaus - Thu @ 06:11am Re: Site paid for by advertizing by knowmad - Wed @ 08:07pm
|
