| Previous · Next | |
| User | Message |
|
dionak
|
Date: 4/17/2007 11:19 am · Subject: DynamicField · Rating: -4
I'm using WebGUI::Form::DynamicField in a custom wobject. I don't appear to be able to adjust the size of the selectList. I'm passing in size as a hashref param but it doesn't appear to have an effect. Is it possible to adjust the size of a selectList using the DynamicField class? $html .= WebGUI::Form::DynamicField->new($self->session, %{$properties} )->toHtmlWithWrapper;
|
| Back to Top |
Rate [ | ]
|
|
fdillon
|
Date: 4/17/2007 11:55 am · Subject: Re: DynamicField · Rating: -4
There is some odd code in Dynamic Field which is preventing this:if (exists $param->{size}) { $size = $param->{size}; delete $param->{size}; } .... ##Fix up methods for List type forms and restore the size to all Forms *except*##List type forms. Historically, dynamically created forms have always##used the default size. if ($formObj->isa('WebGUI::Form::List')) { $formObj->correctValues($param->{value}); $formObj->correctOptions($param->{possibleValues});}elsif ($size) { $formObj->set('size',$size);} The comments seem to specify that when Dynamically creating a list, the default size must be used but no indication as to why this is. Unless there is a good reason for not allowing dynamically created lists to specify size, this should probably be removed. On Apr 17, 2007, at 11:19 AM, <diona@knowmad.com> <diona@knowmad.com> wrote: dionak wrote: |
| Back to Top |
Rate [ | ]
|
|
dionak
|
Date: 4/17/2007 12:18 pm · Subject: Re: DynamicField · Rating: -3
Perhaps this is best reported as a bug? |
| Back to Top |
Rate [ | ]
|
|
colink
|
Date: 4/17/2007 1:24 pm · Subject: Re: DynamicField · Rating: -2
I remember that code from all the way back when WebGUI was inCVS. It's been around for a long time. I would make this an RFE, and that would allow JT to weigh in on anything that isn't obvious on inspection. |
| Back to Top |
Rate [ | ]
|
|
fdillon
|
Date: 4/17/2007 1:40 pm · Subject: Re: DynamicField · Rating: 7
Dione,If it is something you need and are willing to contribute (fixing DynamicField.pm), email JT and ask him if he'd be wiling to allow the change in the next release. Otherwise this one might not see a change for quite some time. On Apr 17, 2007, at 1:24 PM, <ckuskie@sterlink.net> wrote: colink wrote: |
| Back to Top |
Rate [ | ]
|
|
dionak
|
Date: 4/17/2007 1:46 pm · Subject: Re: DynamicField · Rating: 0
I submitted a bug report but I'll go ahead and create a patch, submit it as an RFE and email JT to cover all bases. Thanks. |
| Back to Top |
Rate [ | ]
|
|
JT
|
Date: 4/17/2007 2:15 pm · Subject: Re: DynamicField · Rating: -7
I didn't write that section of code. And I don't have any recollection of why size should not be allowed on dynamically created lists. Go ahead and change it for yourself, and submit an RFE with a patch for 7.4.
|
| Back to Top |
Rate [ | ]
|
|
dionak
|
Date: 4/17/2007 2:31 pm · Subject: Re: DynamicField · Rating: 13
Is this the correct command for checkout out from SVN? svn co https://svn.webgui.org/svnroot/WebGUI I'm getting the following: svn: PROPFIND request failed on '/svnroot/WebGUI' Btw, I just want to use this to create the patch against 7.4. |
| Back to Top |
Rate [ | ]
|
|
dionak
|
Date: 4/17/2007 2:34 pm · Subject: Re: DynamicField · Rating: 3
nvrmind. i should read my email more often. svn co https://svn.webgui.org/plainblack/WebGUI |
| Back to Top |
Rate [ | ]
|
