| Previous · Next | |
| User | Message |
|
JT
|
Date: 2/20/2008 12:35 am · Subject: C2: oops · Rating: 6
I must have been smoking some serious peyote when I wrote the ship and pay docs for the new commerce system. They were really hosed. Sorry for that. The new versions are checked into svn now. JT Smith ph: 703-286-2525 x810 fx: 312-264-5382 Create like a god. Command like a king. Work like a slave. |
| Back to Top |
Rate [ | ]
|
|
JT
|
Date: 2/21/2008 11:18 am · Subject: C2: Ship & Pay Driver Change · Rating: 18
I'm considering that maybe we should take the class methods from WebGUI::Shop::Pay and WebGUI::Shop::Ship and move them into WebGUI::Shop::PayDriver and WebGUI::Shop::ShipDriver. We can then of course rename those classes to the shorter versions of the name. My reason for this is to make it more consistent with the asset API. With asset instead of having this external class with it's own new() method, we create other methods like newByDynamicClass(). I'm not sure which way is better, but one thing that is definitely better is consistency. Colin, Joeri, and Arjan, since you guys are the ones working on this stuff, what is your opinion? |
| Back to Top |
Rate [ | ]
|
|
colink
|
Date: 2/21/2008 12:42 pm · Subject: Re: C2: Ship & Pay Driver Change · Rating: 0
Speaking for Ship only... I don't see any problems. create becomes createByClassname. We also move _loadDriver to ShipDriver. getShippers translates straight across, no issues. getDrivers translates straight across, no issues. That leaves Shop::Ship with the www methods, www_listShippers, www_editShipper, www_editShipperSave. |
| Back to Top |
Rate [ | ]
|
|
JT
|
Date: 2/21/2008 2:25 pm · Subject: Re: C2: Ship & Pay Driver Change · Rating: 3
> Speaking for Ship only...> > I don't see any problems. > > create becomes createByClassname. We also move _loadDriver to > ShipDriver. > > getShippers translates straight across, no issues. > > getDrivers translates straight across, no issues. > > That leaves Shop::Ship with the www methods, www_listShippers, > www_editShipper, www_editShipperSave. > No it doesn't. There is no Shop::Ship anymore. Or rather Shop::ShipDriver becomes Shop::Ship and Shop::ShipDriver no longer exists. JT Smith ph: 703-286-2525 x810 fx: 312-264-5382 Create like a god. Command like a king. Work like a slave. |
| Back to Top |
Rate [ | ]
|
|
JT
|
Date: 2/21/2008 2:30 pm · Subject: Re: C2: Ship & Pay Driver Change · Rating: 13
On second thought, just forget about it. It works fine the way it is.JT Smith ph: 703-286-2525 x810 fx: 312-264-5382 Create like a god. Command like a king. Work like a slave. |
| Back to Top |
Rate [ | ]
|
