plainblack.com
Username Password
search
Community Support
WebGUI User Guides
Wiki
Forums
Report A Bug
Request Features
WebGUI 8
WebGUI TV
Add-ons and Plug-ins
Service Providers
webGUI in the news
Karma
API Docs
the people behind wg
webgui worldwide
Mascot
wallpapers
powered by icons
Sightings
Bookmark and Share
View All Tickets
Errors in Calendar Event Edit template  (#11471)
Issue

WebGUI's Default Calendar Event Edit template (root/import/calendar-templates/default-calendar-event-edit) has one error in the template itself and one error in the CSS. The errors were discovered in 7.7.29, and have been confirmed in 7.7.32 via the webgui.org demo website.

  1. There are extra closing tags for tables and table elements, which can wreck havoc on pages that use tables for their layout. The extra tags are lines 101 through 104, according to the Code Editor, consisting of two table close tags and one each table cell and table row tag.

    The table that begins on line 24 (id="event" just after the "Event tab" comment) ends at line 100, and the closing tags on lines 101-104 don't correspond to any opening tags that preceed them in the template.

  2. In the Extra Head Tags, line 22 (under #tabs a) there is a semicolon after "text-align" which should be a colon.

I have attached edited versions of the template components to this bug report. For #1, look for the comment "Extra tags removed here" and for #2, look for the comment "The following declaration has been fixed".

Solution Summary
Comments
Trex
0
3/13/2010 4:24 pm 		I would also like to request that the template be changed to limit the scope of the CSS in the Extra head tags. The CSS currently there is not restrictive enough to prevent it from impacting elements outside the event form. The template has no overall wrapper, but instead consists primarily of three separate tables. The best solution would probably be to wrap the entire output in a div with a given ID, then make sure the CSS only affects elements that fall within this div.

Problematic statements include "body *", "table td", "table a", "input" and "select".
perlDreamer
0
3/13/2010 5:34 pm 		Couple of things:

1) Thanks very much for the HTML fragments to help change that.  In the future, you could just upload a package, and let us do the diffing on our end to double check the changes.

2) If you want to upload a package with the suggested wrapper and changes to CSS, in a separate ticket, we'll can consider it a bug.  You may want to check the TWG forum and website to see if someone else has already volunteered to do that.
Trex
0
3/14/2010 0:21 am 		Does the attached wgpkg file work for both, without needing to file a new bug? It is from a system running 7.7.29. The main difference with 7.7.32 appears to be the addition of $1 in place of empty rows.

This package includes fixes to (1) remove the extra table tags, (2) fix the CSS colon/semicolon error, (3) wrap the output in a div and updated CSS to limit scope of styles to those elements contained within the div, and (4) add 4px padding between form labels and the form elements (my own stylistic decision). I checked the design forums and did not see any discussion of this particular template. Hopefully this does not duplicate anyone else's work (though it's really not much work to begin with).

To be honest, I have not used WebGUI's package features before, because I had it confused with the HTML export feature. But if this is the best way to submit template-related fixes, and if I'm doing it correctly, it seems a handy way to go about contributing back.
perlDreamer
0
3/15/2010 11:45 am 		Packages are definitely better than HTML files, and it's the best way to share assets, whether they are templates, snippets, articles, layouts, navigations or whatever.

I'll review the syling change as it's not really related to the bug.  It may have to be removed.

In general, it's best to have 1 topic per bug posting, to make it easy for people to scan bug titles.
perlDreamer
0
3/15/2010 12:20 pm 		Added the package to

7.9.1 (4fa04a2)
7.8.15 (5efa9bc 5463f96)
Trex
0
3/15/2010 12:36 pm 		Thanks! No worries if the style change is omitted. Personally I think it's ugly to have text abutting the form fields, but I can easily change that on my own without needing it in the core.
Details
Ticket Status Closed  
Rating0.0 
Submitted ByTrex 
Date Submitted2010-03-13 
Assigned To unassigned  
Date Assigned2012-02-11 
Assigned By 
Severity Minor (annoying, but not harmful)  
What's the bug in? WebGUI Stable  
WebGUI / WRE Version 7.7.32 & whatever webgui.org runs for WRE  
URLuse/bugs/tracker/11471
Keywords
Related Files
Ticket History
3/15/2010
12:36 PM 		Closed Trex
3/15/2010
12:20 PM 		Resolved perlDreamer
3/13/2010
4:04 PM 		Ticket created Trex
© 2012 Plain Black Corporation | All Rights Reserved