plainblack.com
Username Password
search
Bookmark and Share
View All Tickets
Upgrade errors -- 7.6.35 to 7.7.17  (#11034)
Issue

I received the following error message while testing an upgrade:

--------------------------------------------------------------

7.6.35 - 7.7.17

Adding template packing/minifying...
        Pre-packing all templates, this may take a while...
        Adding extra head tags packing...
        Pre-packing all head tags, this may take a while...
        Adding snippet packing...
        Pre-packing all snippets, this may take a while...Backslash found where operator expected at (eval 13191) line 1, near "q/\/^(https?|ftp):\\\/\\\/(((([a-z]|\\d|-|\\.|_|~|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])|(%[\\da-f]{2})|[!\\q/ \"
String found where operator expected at (eval 13191) line 1, at end of line
    (Missing operator before '\\(\\)\\*\\+,;=]|:)*@)?(((\\d|[1-9]\\d|1\\d\\d|2[0-4]\\d|25[0-5])\\.(\\d|[1-9]\\d|1\\d\\d|2[0-4]\\d|25[0-5])\\.(\\d|[1-9]\\d|1\\d\\d|2[0-4]\\d|25[0-5])\\.(\\d|[1-9]\\d|1\\d\\d|2[0-4]\\d|25[0-5]))|((([a-z]|\\d|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])|(([a-z]|\\d|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])([a-z]|\\d|-|\\.|_|~|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])*([a-z]|\\d|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])))\\.)+(([a-z]|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])|(([a-z]|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])([a-z]|\\d|-|\\.|_|~|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])*([a-z]|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])))\\.?)(:\\d*)?)(\\\/((([a-z]|\\d|-|\\.|_|~|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])|(%[\\da-f]{2})|[!\\q/ \/^(https?|ftp):\\\/\\\/(((([a-z]|\\d|-|\\.|_|~|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])|(%[\\da-f]{2})|[!\\$&'?)
Backslash found where operator expected at (eval 13191) line 1, near "\"
    (Missing operator before \?)
Backslash found where operator expected at (eval 13191) line 1, near ")\"
    (Missing operator before \?)
Backslash found where operator expected at (eval 13191) line 1, near "*\\"
    (Missing operator before \?)


-----------------------------

Any ideas?

Solution Summary
Comments
perlDreamer
0
9/24/2009 11:35 am
What version of perl are you using?

What versions of HTML::Packer, CSS::Packer, and Javascript::Packer?

And can you post the snippet that is failing?  You may have to add some debug code to the upgrade script to get it to tell you which one it is working on when the error occurs.
knowmad
0
9/24/2009 12:40 pm
I should add that the upgrade process completed successfully despite the errors.

I've found the snippet that is choking the upgrade and will attach it to this report. It's a Javscript file for jquery (and it has the proper mime type set in the snippet asset).

Perl version => This is perl, v5.8.8 built for x86_64-linux (yes, I custom built the WRE on a 64-bit Ubuntu workstation)

Compact modules:
Javascript::Packer - v0.02
knowmad
0
9/24/2009 1:18 pm
I've written a perl test script which confirms that this is an error in the JavaScript::Packer module. I've also submitted this report to CPAN.

perlDreamer: I looked at t/Asset/snippet.t to see if there was a packing test. I didn't see one. Would that be the right place to add some version of the test code that I've created?
knowmad
0
9/24/2009 1:20 pm
One more question:

What is the impact of this problem on WebGUI? Will it make a site unstable or just prevent the snippet from being optimized?
knowmad
4
9/24/2009 1:25 pm
CPAN bug report --> http://rt.cpan.org/Public/Bug/Display.html?id=49982
perlDreamer
0
9/24/2009 3:40 pm
The impact would be felt if the asset was set to use packing.  It would deliver a badly packed snippet.
perlDreamer
0
9/24/2009 6:02 pm
See the CPAN ticket referenced in the comments above.
Waiting on External by perlDreamer
knowmad
0
9/25/2009 2:37 pm
Since packing is a new feature, I have a few questions:

1. How do I know if the asset is set to use packing? nevermind, i found the answer while investigating the impact; it's set via the snippet editor screen

2. Does the upgrade script set assets to enable packing or does it disable packing? Looking at the code, I'd think it defaults to disabling. However, the name of the subroutine (addTemplatePacking) and the comment ("Adding template packing/minifying...") is confusing.


In regards to the impact, in this case, I think that he packed snippet is essentially the same as the unpacked snippet (although the packed version contains WebGUI-specific stuff in it).
preaction
0
9/25/2009 3:01 pm
The first upgrade enables it. A version later it gets disabled because there were apparently problems with it (plainblack.com got broke).

So, like perltidy, this is something we'll have to do slowly and manually, testing all the way to make sure nothing breaks.

If anyone wants to start enabling packing on core snippets and templates and verifying that they work, we can start using this feature. If they could be using Selenium IDE while they're doing so, that'd be even better.
perlDreamer
0
1/19/2010 10:33 am
0.04 was released January 4th, 2010
perlDreamer
0
1/19/2010 11:01 am
Updated the version in testEnvironment.pl, and added a test for packing the gnarly jquery JS.

Fixed in 7.8.10 (ea53dcc)
Fixed in 7.7.31 (858c366)
Details
Ticket Status Resolved  
Rating4.0 
Submitted Byknowmad 
Date Submitted2009-09-24 
Assigned To unassigned  
Date Assigned2019-07-20 
Assigned By 
Severity Cosmetic (misspelling, formatting problems)  
What's the bug in? WebGUI Stable  
WebGUI / WRE Version 7.7.20  
URLuse/bugs/tracker/11034
Keywords
Related Files
Ticket History
1/19/2010
5:01 PM
Resolved perlDreamer
9/24/2009
11:02 PM
Waiting on External perlDreamer
9/24/2009
4:27 PM
Ticket created knowmad
© 2019 Plain Black Corporation | All Rights Reserved