plainblack.com
Username Password
search
Bookmark and Share
Settings keyword highlighting in search wobject  (#11309)
Issue

At the moment the highlighting of keywords in the title and synopsis is done automatically by HTML::Highlight. It would be nice if the Search asset had settings for at least color, background color and font-style (strong, italic etc).

Another option would be to put  the keywords in a span with a class, so it is fully stylable.

Comments
rogier
0
2/22/2010 6:25 am
I would much prefer a span with a class (e.g. "wg-highlight") over inline styles. We can add the default style to wg-base.css. Then we have a good default, users can override it if they want and it can be reused in other searches (wiki etc.).

Please approve this RFE, I would like to add some karma.

Thanks,

Rogier
preaction
0
3/3/2010 8:22 pm
I also would prefer a class with a style, but it will take longer than a set of colors (which is done automatically by HTML::Highlight).

I'll update the difficulty for doing span class="wg-highlight"

Approved.
rogier
0
3/4/2010 3:24 am
Great! Karma added.

To whomever implements this: please give me a heads up when the change will be committed so I can supply the wg-base.css with the highlight class added.
bartjol
0
3/4/2010 5:47 am
I do have a complication for this, right now the HTTP::Highlight module highlights different keywords with a different style. If we want to keep this, a lot of depth (for search term 1 to x) should be taken into account.
rogier
0
3/4/2010 6:41 am
I see. So we should probably add two classes to the span: one for a generic highlight and one for a keyword-specific highlight. So searching for "ipsum dolor" would result in:

Lorem <span class="wg-highlight keyword1">ipsum</span> <span class="wg-highlight keyword2">dolor</div> sit amet.

I admit it's a bit bulky, but it allows designers to set a default style (wg-highlight) and, optionally, a style for each keyword up to keywordN.

Will there be any more complications to up the difficulty or is that it? :-)
bartjol
0
3/4/2010 6:57 am
Not that I'm aware of right now
preaction
0
3/4/2010 7:22 pm
Difficulty updated.

We can probably get away with allowing only 5 different colors and repeating them. Too many colors and it'll just look weird. Agree/Disagree?
rogier
0
3/5/2010 8:30 am
Agreed. I suppose the current highlight module uses a limited number of colors too?
Details
Ticket Status Pending  
Rating0.0 
Submitted By bartjol  
Date Submitted2009-12-15 
Assigned To unassigned  
Date Assigned 2012-02-12  
Assigned By  
What to improve? WebGUI Stable  
URLrfe/request-for-enhancement/11309
Karma
Difficulty 8  
Karma So Far5000
Karma Rank625.00
Keywords
Ticket History
3/8/2010
3:38 AM
1000 karma transfered bartjol
3/4/2010
7:22 PM
Difficulty changed to 8 DBell
3/4/2010
3:23 AM
2000 karma transfered rogier
3/4/2010
2:41 AM
2000 karma transfered bartjol
3/3/2010
8:22 PM
Difficulty changed to 5 DBell
12/15/2009
7:39 AM
Ticket created bartjol
© 2012 Plain Black Corporation | All Rights Reserved