| Previous · Next | |
| User | Message |
|
rogier
|
Date: 10/15/2009 4:18 am · Subject: AssetId may break html comments · Rating: 0
At the WUC, I was told that an assetId in an HTML comment may break the comment if the assetId contains two or more subsequent dashes. (Or are they called hyphens?) This will cause the full comment to render on the page. In the new default templates we use this frequently, at least once per template, like so: <!-- /article<tmpl_var assetId> --> I can think of a couple of solutions:
I assume that with TT, something like this is possible: [% assetId FILTER safeForComment %] But I don't think we want to use TT, if we can find a solution in the backend. So I would prefer option 2.
Rogier | United Knowledge |
| Back to Top |
Rate [ | ]
|
|
perlDreamer
|
Date: 10/17/2009 12:22 pm · Subject: Re: AssetId may break html comments · Rating: 0
There's a bug open for this, assigned to tabb. http://www.webgui.org/use/bugs/tracker/10932
|
| Back to Top |
Rate [ | ]
|
|
rogier
|
Date: 10/19/2009 3:38 am · Subject: Re: AssetId may break html comments · Rating: 0
OK, I'll keep that in mind. Rogier | United Knowledge |
| Back to Top |
Rate [ | ]
|
|
perlDreamer
|
Date: 11/19/2009 5:42 pm · Subject: Re: AssetId may break html comments · Rating: 0
Is using a different format for the assetId acceptable? assetId are normally in a slightly modified base64 format. If we were to use hexadecimal, the assetId is longer, but only uses alphanumerics, so there would be no problems in the comments. |
| Back to Top |
Rate [ | ]
|
|
arjan
|
Date: 11/20/2009 4:50 am · Subject: Re: AssetId may break html comments · Rating: 0
I think it's a very good idea only to use alphanumerics. Kind regards, Arjan Widlak United Knowledge |
| Back to Top |
Rate [ | ]
|