plainblack.com
Username Password
search
Bookmark and Share
View All Tickets
CS branch error  (#3196)
Issue

I try to change "hide from navigation" using edit branch on a cs thread. I CAN change from No to Yes but not from Yes to No!

 

This is how to reproduce this error:

1. Create cs

Hide from navigation set to No

2. Commit

3. Create threads

I create two threads (both inherit hide fromnavigation No from parent)

4. Edit branch on a thread
In order to a thread property I need to use edit branch from asset manager.

So I edit branch on the first thread and change Hide from navigation to Yes

This works and the first thread diappears

5.  Edit back

Same procedure but I Hide from navigation set to No
ERROR: nothing happens and the property is not set. Hide from navigation still Yes.

 

I havnt checked the code, hopefully this is not a common bug for all assets but just for a collaboration thread.

/Erik 

 

Solution Summary
Comments
perlDreamer
0
6/24/2007 5:19 pm

There's some code in Post/addRevision that forces isHidden=1, so it looks like Posts were not supposed to be visible in navigations.  However, when a Thread is added, processPropertiesFromFormPost is called after addRevision inside www_editSave, so isHidden=1 is overridden with the parent's properties.

When editBranch is called, it calls addRevision, but processPropertiesFromFormPost is never called, so the code works like it should and forces isHidden=1.

I have no idea how to fix this, or if it should be an RFE to allow Posts to be visible inside navigations. 

perlDreamer
0
6/24/2007 5:27 pm

Wiki pages will also have this problem.

Events have a different problem.  isHidden=1 is set inside processPropertiesFormFormPost.  That means isHidden can be turned off via editBranch.

perlDreamer
0
6/25/2007 4:36 pm

Talked with JT about this bug on IRC:

1) It is a bug that isHidden can ever be set to 0 on Post, Wiki or Event Assets.

2) He's not too interested in adding that ability (set isHidden to 0) as a core feature.

As of 7.3.19/7.4.0, isHidden will be forced to 1 on those three Assets.

perlDreamer
0
6/25/2007 11:34 pm
Fixed in 7.3.19.  The fix was forward ported to 7.4.0 as well.
Details
Ticket Status Closed  
Rating0.0 
Submitted Byerik.svanberg 
Date Submitted2007-06-20 
Assigned To unassigned  
Date Assigned2019-08-25 
Assigned By 
Severity Minor (annoying, but not harmful)  
What's the bug in?  
WebGUI / WRE Version 7.3.18  
URLbugs/tracker/cs-branch-error
Keywords
Ticket History
© 2019 Plain Black Corporation | All Rights Reserved