WebGUI - Hardcoded extras in files in www/extras - Content Management System Website - CMS - Open Source Content Management System Website - Website System - Content Management System (CMS) | Open Source Content Management Software | Application Framework | WebGUI - Content Management System Website | CMS | WebGUI | Open Source Content Management System Website

Username Password

Home Features Sightings Download Partners Community

Community Support
Wiki
Forums
Report A Bug
Request Features
WebGUI 8
WebGUI TV
Marketplace
Calendar
webGUI in the news
Karma
API Docs
Roadmap
the people behind wg
webgui worldwide
Mascot
wallpapers
Stats
powered by icons

View All Tickets

Hardcoded extras in files in www/extras (#10486)

Issue

These files all have hardcoded extras URLs:

yui-webgui/build/datepicker/example.html
ukplayer/content.xml
ukplayer/config.xml
ukplayer/slideshow.html
styleDesigner/example.html
colorpicker/example.html
accordion/example-transitional.html
accordion/example-strict.html
accordion/example-nodoctype.html
wobject/Survey/surveyedit.css
wobject/Survey/administersurvey.js
wobject/Profiler/sortabletable.js
wobject/ProjectManager/projectDisplay.js
wobject/Shortcut/querybuilder.css
WebGUI.js

Solution Summary

Comments

rogier 6/8/2009 2:40 am	I'll fix the ones in the UKplayer stuff. The URLs have to be replaced with the Extras macro, right?
perlDreamer 6/8/2009 9:32 am	No. None of these files are processed are processed for macros, so using the Extras macro is just as broken as hardcoding the URL. For javascript, check out how the assetManager js (yui-webgui/assetManager/assetManager.js) gets the extras URL from lib/WebGUI/Content/AssetManager.pm.
perlmonkey2 6/8/2009 2:22 pm	survey files are correct. JS now uses getWebguiProperty('extrasURL') and css was moved to a snippet.
perlDreamer 6/8/2009 6:04 pm	After some IRC talking, it seems the right way to do this for CSS is to use relative URLs. Another option is that all CSS would need to be a snippet.
perlDreamer 6/9/2009 11:52 am	The Survey files are fixed, the example files are just examples (they're not used anywhere), the ProjectManager JS is okay and the Shortcut css file and the PerformanceProfiler sorttable js has been fixed. That just leaves these files: ukplayer/content.xml ukplayer/config.xml ukplayer/slideshow.html WebGUI.js WebGUI.js isn't used in any perl, javascript or templates that I can find.
perlDreamer 6/11/2009 10:01 am	Fixed in 7.6.27 and 7.7.10 Resolved by perlDreamer

Details

Ticket Status	Resolved
Rating
Submitted By	perlDreamer
Date Submitted	2009-06-05
Assigned To	unassigned
Date Assigned	2010-07-31
Assigned By
Severity	Minor (annoying, but not harmful)
What's the bug in?	WebGUI Stable
WebGUI / WRE Version	7.x
URL	bugs/tracker/10486

Keywords

Ticket History

6/11/2009 10:01 AM	Resolved	perlDreamer
6/5/2009 6:53 PM	Ticket created	perlDreamer